-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new EventSchema and SchemaRegistry API #4
Conversation
This PR is ready for final review. The only test that's failing is the "check-links" test in the documentation, which is failing because the new docs refer to links that will be created once this PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APIs look good to me, just one minor question
Thanks, @blink1073! I addressed various comments from @kevin-bates in #2 too. I'll likely merge this here work on getting the documentation rendering. Then, I'll shift to integrating with Jupyter Server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zsailer - this looks good. Sorry about focusing on #2 rather than this PR. Looks like the majority of comments are not applicable in this version (nice!). This is the only comment that's tbd, but that's something that we can look into later and/or doesn't affect the service overall.
@kevin-bates I think I addressed that comment in this commit: 8d43c5b |
Thanks @Zsailer. It looks like that warning will (also) be issued if there are no handlers, yet have registered (and matching) schema/version pairs - which, I suspect, will be common and probably not worthy of a warning. I was thinking only the missing schema/version pair scenario would be logged. |
Ah, yes. Thanks, Kevin! Fixed in 4659ddf |
This proceeds the work in #2. The review in that PR became focused on "categories" and "redactionPolicies". I'm open this PR here to keep that discussion in tact while moving the review of the basic API design (minus the categories stuff) here.
Highlights
EventSchema
API for validating schemas and events.SchemaRegistry
to cache validators for all registered schemas. This prevents a memory leak I have been seeing this library.Public API changes
EventLogger.record_event
has been renamed toEventLogger.emit
.